Skip to content

Conversation

@luanne
Copy link
Contributor

@luanne luanne commented Jan 13, 2026

Minor tweaks to get the guide running:

  • Update readme to start the application with Neo4j (current readme only starts Neo4j).
  • Fix issue with tests when running the Docker java app.
  • Make Neo4j ports configurable.

…ts when running the Docker java app. Make Neo4j ports configurable.
jmjava added a commit to jmjava/guide that referenced this pull request Jan 17, 2026
- Delete CURSOR-PR.md (migrated to README.md previously)
- Fix Dockerfile: add codegen-gradle copy and chmod +x for gradlew
- Make Neo4j ports configurable via NEO4J_HTTP_PORT, NEO4J_BOLT_PORT, NEO4J_HTTPS_PORT
- Add Docker Build Details section to README.md
- Update Environment Variables table with Neo4j port configs

Closes embabel#24
Incorporates changes from PR embabel#25
@jmjava
Copy link
Contributor

jmjava commented Jan 17, 2026

Hi - i incorporated these changes into the next pr also. Startup working for me - thanks for fixing the dockerfile

jmjava added a commit to jmjava/guide that referenced this pull request Jan 17, 2026
- Delete CURSOR-PR.md (migrated to README.md previously)
- Fix Dockerfile: add codegen-gradle copy and chmod +x for gradlew
- Make Neo4j ports configurable via NEO4J_HTTP_PORT, NEO4J_BOLT_PORT, NEO4J_HTTPS_PORT
- Add Docker Build Details section to README.md
- Update Environment Variables table with Neo4j port configs

Closes embabel#24
Incorporates changes from PR embabel#25
jmjava added a commit to jmjava/guide that referenced this pull request Jan 17, 2026
- Delete CURSOR-PR.md (migrated to README.md previously)
- Fix Dockerfile: add codegen-gradle copy and chmod +x for gradlew
- Make Neo4j ports configurable via NEO4J_HTTP_PORT, NEO4J_BOLT_PORT, NEO4J_HTTPS_PORT
- Add Docker Build Details section to README.md
- Update Environment Variables table with Neo4j port configs

Closes embabel#24
Incorporates changes from PR embabel#25
jmjava added a commit to jmjava/guide that referenced this pull request Jan 17, 2026
jmjava added a commit to jmjava/guide that referenced this pull request Jan 17, 2026
jmjava added a commit to jmjava/guide that referenced this pull request Jan 18, 2026
@jasperblues jasperblues merged commit f4f1459 into embabel:main Jan 18, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants